Repository navigation
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/1c8d51699fbf7e6d2ac5423e7da78710d87379eeOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 1c8d516 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # packages/kit/src/runtime/server/cookie.spec.js # packages/kit/src/runtime/server/page/csp.spec.js # packages/kit/vitest.kit.config.js
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15938 added
'unsafe-allow-redirects','unsafe-webtransport-hashes'and'trusted-types-eval'to theCsp.BaseSourcetype, but not to thequotedset incsp.js. So they are written into the header without quotes:Browsers read an unquoted keyword as a host source named
trusted-types-eval, and the keyword itself has no effect. The same goes for'allow-duplicates'in thetrusted-typesdirective (its type is'none' | 'allow-duplicates' | '*' | string): unquoted, it is read as a policy name. This PR adds the four keywords toquoted.An earlier version of this PR also re-enabled the prod CSP/cookie test suites, which Vitest 5's own
process.env.DEVwas skipping. #17436 has since fixed that onmain, so I mergedmainand dropped that part. The PR now only touchescsp.js, its spec and the changeset.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkThe new
quotes the other keyword sourcestest fails without the change tocsp.js, with the keywords unquoted. The CSP and cookie specs (68 tests) andpnpm lintpass.Changesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.